3 years ago

Category: github

Unfortunately, many of these pull requests have been a waste of time, with the maintainers ultimately unable to use the contributions. Maintainers don’t want to waste their time reviewing bad PRs, and contributors don’t want to waste their time writing code that will never make it into production.

Small diffs decrease the cognitive load of the reviewer and make it easier to get your code into the main branch.

Well-intentioned developers open pull requests with any of the following annoyances: When you contribute to an existing project, use the existing styling.

No one wants to read your duplicate issue or review your duplicate pull request.